Skip to content

chore(CI): Fix TestVectors timeout #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

lucasmcdonald3
Copy link
Contributor

Issue #, if available:

Description of changes:

Fix a timeout in TestVectors by removing redundant test scenarios.

CodeBuild CI has tests that decrypt generated vectors with both keyrings and MKPs.
However, the keyrings step actually decrypts with both keyrings and MKPs.
This change removes the MKP decryption from the keyrings step, since it is redundant.

This change fixes a timeout in CodeBuild CI.
CodeBuild CI times out after 60 minutes.
Before this change, CI would time out at roughly 60 minutes, but would sometimes succeed.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@lucasmcdonald3 lucasmcdonald3 changed the title chore(CI): chore(CI): Fix TestVectors timeout Oct 28, 2024
@lucasmcdonald3 lucasmcdonald3 marked this pull request as ready for review October 28, 2024 21:40
@lucasmcdonald3 lucasmcdonald3 requested a review from a team as a code owner October 28, 2024 21:40
@lucasmcdonald3 lucasmcdonald3 merged commit 2bdd114 into mpl-reviewed Oct 28, 2024
227 checks passed
@lucasmcdonald3 lucasmcdonald3 deleted the fix-timeout branch October 28, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants